fix: missing dependabot updates #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Since ebe7d3c, dependabot does not send updates for packages not matching a group. For example, in the "telemetry/vscode/" directory it will only update `jest` and `@types` dependencies. Other deps won't be updated. Hint: #533 (comment) Solution: - Review the inscrutable documentation: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file - Reference examples on github via: https://github.com/search?q=path%3Adependabot.yml+groups+all&type=code - Remove `dependency-type` directive. - Try `allow: dependency-name: '*'` directive. - If this doesn't work, later try a "catch-all" group. Note that `groups` are evaluated as "first wins". - Note: intentionally _not_ using ["allow: dependency-type:all" directive](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow); it enables updates for _transitive_ dependencies.
|
There is no way to validate dependabot configs without commiting, so just going to yolo this. Edit: can troubleshoot dependabot here: https://github.com/aws/aws-toolkit-common/network/updates |
|
config is valid: https://github.com/aws/aws-toolkit-common/runs/20382074101 dependabot logs are here: https://github.com/aws/aws-toolkit-common/network/updates |
justinmk3
added a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Jan 11, 2024
Problem: Dependabot updates are much less frequent. No way to troubleshoot, but correlates with the `groups` directive added in 06507c3 (4 months ago). Hint: aws/aws-toolkit-common#533 (comment) Solution: - Review the inscrutable documentation: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file - Reference examples on github via: https://github.com/search?q=path%3Adependabot.yml+groups+all&type=code - Remove the `dependency-type: production` directive. - Add the `allow: dependency-name: *` directive. - Note: intentionally _not_ using ["allow: dependency-type:all" directive](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow); it enables updates for _transitive_ dependencies. see also aws/aws-toolkit-common#666
justinmk3
added a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Jan 11, 2024
Problem: Dependabot updates are much less frequent. No way to troubleshoot, but correlates with the `groups` directive added in 06507c3 (4 months ago). Solution: - Review the inscrutable documentation: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file - Remove the `dependency-type: production` directive. - Add the `allow: dependency-name: *` directive. - Note: intentionally _not_ using ["allow: dependency-type:all" directive](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow); it enables updates for _transitive_ dependencies. see also aws/aws-toolkit-common#666
justinmk3
added a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Jan 11, 2024
Problem: Dependabot updates are much less frequent. No way to troubleshoot, but correlates with the `groups` directive added in 06507c3 (4 months ago). Solution: - Review the inscrutable documentation: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file - Remove the `dependency-type: production` directive. - Add the `allow: dependency-name: *` directive. - Note: intentionally _not_ using ["allow: dependency-type:all" directive](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow); it enables updates for _transitive_ dependencies. see also aws/aws-toolkit-common#666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Since ebe7d3c,
dependabot does not send updates for packages not matching a group.Note
Edit: this premise might be false; counterexample is #635 , which was created after ebe7d3c )
Hint: #533 (comment)
Solution:
dependency-typedirective.allow: dependency-name: '*'directive.groupsare evaluated as "first wins".License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.